Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize “bucket exists” checks #209

Open
sa7mon opened this issue Sep 18, 2023 · 0 comments
Open

Optimize “bucket exists” checks #209

sa7mon opened this issue Sep 18, 2023 · 0 comments
Labels
refactor Code cleanup / optimization

Comments

@sa7mon
Copy link
Owner

sa7mon commented Sep 18, 2023 •
edited
Loading

  • Some providers like Scaleway return an x-amz-bucket-region header in the response to a HEAD request. In those cases, we can just make one request to any region.
  • AWS and GCP definitely return the region after a single request. Make sure we’re not sending superfluous requests for each region client we’ve created while scanning.
  • Switch providers to PathStyle, if they support it, to reduce DNS lookups.
  • Measure the number of network requests (both HTTP and DNS) made before and after these changes

https://github.com/gaul/undocumented-s3-apis/
@sa7mon sa7mon added the refactor Code cleanup / optimization label Sep 18, 2023
@sa7mon sa7mon mentioned this issue Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Code cleanup / optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sa7mon