Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node10 #3

Closed
rzr opened this issue Nov 14, 2018 · 3 comments
Closed

Support Node10 #3

rzr opened this issue Nov 14, 2018 · 3 comments

Comments

@rzr
Copy link
Owner

rzr commented Nov 14, 2018

Blocked-by: kelly/node-i2c#90
@rzr
Copy link
Owner Author

rzr commented Feb 27, 2019

Relate-to: SamsungInternet/color-sensor-js#2

@rzr
Copy link
Owner Author

rzr commented Mar 10, 2019

BTW maybe we can look for I2C module supporting also darwin , as @MatonAnthony reported that i2c is linux only, so it was made optional for simulators:

#5

rzr added a commit that referenced this issue Mar 25, 2019
@rzr
Revert "example: Use controllers not simulators"
ce77926 
This reverts commit 035bb65.

Bug: #3
Change-Id: I412ee9d80abe565ea5402f61f0c4bcac6514228a
rzr added a commit that referenced this issue Mar 27, 2019
@rzr
Revert "example: Use controllers not simulators"
6e6b410 
This reverts commit 035bb65.

Bug: #3
Change-Id: I412ee9d80abe565ea5402f61f0c4bcac6514228a
@rzr rzr mentioned this issue Jul 15, 2019
Closed
rzr added a commit that referenced this issue Jul 16, 2019
@rzr
npm: Depends on bh1750 from abandonware
b07cb05 
To support node-10

Bug: #3
Change-Id: Iedcd1e7e3fa0ea0217ac24bd9bef903324c1a2b4
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr
Copy link
Owner Author

rzr commented Oct 1, 2019

no more dependency to i2c so node10 is supported

Related-to: kelly/node-i2c#97

@rzr rzr closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rzr