Fix starts_with typo in chemkin.py
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwest
added a commit
that referenced
this pull request
May 1, 2018
Addresses the comment in cfgoldsmith#5 (comment) but not actually issue #5.
rwest
added a commit
that referenced
this pull request
Jun 7, 2023
This is a combination of 12 commits, as we tried everything under the sun to debug the CI. But they all cancelled out when merged (apart from fixing a typo in a comment) - This is the 1st commit message: CI: trying to force ubuntu-20.04 instead of ubuntu-latest (temporary) While we figure out what's happening, let's try an older ubuntu. - This is commit message #2: fixup! CI: trying to force ubuntu-20.04 instead of ubuntu-latest (temporary) - This is the commit message #3: Switch back to ubuntu-latest But leave a 20.04 in the matrix build - This is the commit message #4: Trying libstdcxx-ng < 13 in Conda environment. Trying to debug. If this works it should be put in docker file too. Or, better, the real cause found and fixed. - This is the commit message #5: fix typo in env, undo ubuntu os changes, set gcc version in CI to 6 this system object of this version is being provided by gcc, and the runners no longer come prepackaged with it since its old (?) - This is the commit message #6: it wasn't the gcc version - This is the commit message #7: it was the julia version, 1.9.0 is brokey as reported at conda-forge/julia-feedstock#253 the latest release of julia (1.9.0) is brokey, don't use it (put !=1.9.0 in the environment file) - This is the commit message #8: make mac and ubuntu use the same cxx library - This is the commit message #9: but what if it was rdkit all along? - This is the commit message ReactionMechanismGenerator#10: Revert "but what if it was rdkit all along?" because it wasn't - This is the commit message ReactionMechanismGenerator#11: Revert "make mac and ubuntu use the same cxx library" cos it didn't work - This is the commit message ReactionMechanismGenerator#12: Revert "it was the julia version, 1.9.0 is brokey" but it wasn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking strings in chemkin.py error messages.
It should be
startswith(no underscore)