Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG elements' interfaces to web-sys #448

Closed
73 tasks
fitzgen opened this issue Jul 10, 2018 · 7 comments
Closed
73 tasks

Add SVG elements' interfaces to web-sys #448

fitzgen opened this issue Jul 10, 2018 · 7 comments
Labels
help wanted We could use some help fixing this issue! web-sys Issues related to the `web-sys` crate

Comments

@fitzgen
Copy link
Member

fitzgen commented Jul 10, 2018

This is a tracking issue for adding support for adding the SVG elements' interfaces to the web-sys crate.

General info on SVG interfaces: https://developer.mozilla.org/en-US/docs/Web/API/Document_Object_Model#SVG_interfaces

How to add support for new Web APIs to web-sys: https://rustwasm.github.io/wasm-bindgen/web-sys/supporting-more-web-apis.html

Interfaces

Here is a list of interfaces we need to support:

  • SVGAElement
  • SVGAnimationElement
  • SVGAnimateElement
  • SVGAnimateMotionElement
  • SVGAnimateTransformElement
  • SVGCircleElement
  • SVGClipPathElement
  • SVGComponentTransferFunctionElement
  • SVGCursorElement
  • SVGDefsElement
  • SVGDescElement
  • SVGElement
  • SVGEllipseElement
  • SVGFEBlendElement
  • SVGFEColorMatrixElement
  • SVGFEComponentTransferElement
  • SVGFECompositeElement
  • SVGFEConvolveMatrixElement
  • SVGFEDiffuseLightingElement
  • SVGFEDisplacementMapElement
  • SVGFEDistantLightElement
  • SVGFEDropShadowElement
  • SVGFEFloodElement
  • SVGFEFuncAElement
  • SVGFEFuncBElement
  • SVGFEFuncGElement
  • SVGFEFuncRElement
  • SVGFEGaussianBlurElement
  • SVGFEImageElement
  • SVGFEMergeElement
  • SVGFEMergeNodeElement
  • SVGFEMorphologyElement
  • SVGFEOffsetElement
  • SVGFEPointLightElement
  • SVGFESpecularLightingElement
  • SVGFESpotLightElement
  • SVGFETileElement
  • SVGFETurbulenceElement
  • SVGFilterElement
  • SVGFilterPrimitiveStandardAttributes
  • SVGForeignObjectElement
  • SVGGElement
  • SVGGeometryElement
  • SVGGradientElement
  • SVGGraphicsElement
  • SVGImageElement
  • SVGLinearGradientElement
  • SVGLineElement
  • SVGMaskElement
  • SVGMetadataElement
  • SVGMPathElement
  • SVGPathElement
  • SVGPatternElement
  • SVGPolylineElement
  • SVGPolygonElement
  • SVGRadialGradientElement
  • SVGRectElement
  • SVGScriptElement
  • SVGSetElement
  • SVGStopElement
  • SVGStyleElement
  • SVGSVGElement
  • SVGSwitchElement
  • SVGSymbolElement
  • SVGTextContentElement
  • SVGTextElement
  • SVGTextPathElement
  • SVGTextPositioningElement
  • SVGTitleElement
  • SVGTSpanElement
  • SVGUseElement
  • SVGViewElement

Example

  • Add an example to examples/ that shows off working with SVG
@fitzgen fitzgen added help wanted We could use some help fixing this issue! web-sys Issues related to the `web-sys` crate labels Jul 10, 2018
@sepiropht
Copy link
Contributor

It is possible to work on this ? It is manageable for a beginner ?

@fitzgen
Copy link
Member Author

fitzgen commented Aug 21, 2018

@sepiropht we already enabled pretty much all of these interfaces, and we just need sanity testing and an example for working with SVG now. If you'd like to help out with that, it would be very appreciated!

@sepiropht
Copy link
Contributor

sepiropht commented Aug 21, 2018

Ok i can try that.
@fitzgen And by 'sanity testing' you mean testing only the essential ie SVGElement ?

@fitzgen
Copy link
Member Author

fitzgen commented Aug 21, 2018

Similar to stuff like

Basically, we just want to test the essential things for an interface, don't need to test all of an interface's inherited methods or whatever.

We just want to be fairly confident that things are working as expected.

@mstallmo
Copy link
Member

@sepiropht what interfaces were you planning to work on? I was hoping to chip in on this as well but don't want to step on your toes!

@sepiropht
Copy link
Contributor

I will take SVGElement

@mstallmo
Copy link
Member

Cool! I'll start on SVGAElement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We could use some help fixing this issue! web-sys Issues related to the `web-sys` crate
Projects
None yet
Development

No branches or pull requests

3 participants