Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): Correct b2.toml #1072

Merged
merged 9 commits into from
Feb 25, 2024
Merged

fix(doc): Correct b2.toml #1072

merged 9 commits into from
Feb 25, 2024

Conversation

HaleTom
Copy link
Contributor

@HaleTom HaleTom commented Feb 19, 2024 •
edited by aawsome
Loading

closes #1068

@HaleTom
Correct b2.toml
846f216 
- s/key_id/application_key_id/
- Remove generic opendal comment
- Add comment for password file
- Add comment for OpenDAL environment variables
@HaleTom HaleTom mentioned this pull request Feb 19, 2024
Closed
@HaleTom
Copy link
Contributor Author

HaleTom commented Feb 19, 2024

Related:

rustic: OPENDAL_B2_* variables don't work #1073
#1073

opendal: Do OPENDAL_B2_* environment variables work? #4199
apache/opendal#4199

aawsome
aawsome requested changes Feb 19, 2024
View reviewed changes
Copy link
Member

@aawsome aawsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HaleTom for the PR! I have only minor change requests.

config/services/b2.toml Outdated Show resolved Hide resolved
config/services/b2.toml Outdated Show resolved Hide resolved
@aawsome aawsome changed the title Correct b2.toml fix(doc): Correct b2.toml Feb 19, 2024
@HaleTom HaleTom requested a review from aawsome February 22, 2024 12:19
aawsome
aawsome approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@aawsome aawsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @HaleTom

@aawsome aawsome merged commit a39a14d into rustic-rs:main Feb 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aawsome aawsome aawsome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example b2.toml issues
2 participants
@HaleTom @aawsome