-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sound] add a comment to explain latency value #501
Comments
The doc comment can be similar to the commit that introduced the field:
Source: https://lists.oasis-open.org/archives/virtio-dev/201912/msg00123.html |
Right, it is not clear to me yet how the virtio-sound driver uses |
@MatiasVara I had the same thought when I first read the code. My interpretation ended up being that the sound card should not be "kicked" (interrupted) until I don't have strong doubts about this explanation to be honest but the best source for this would surely be the spec authors. |
Do you think you could respond this also here https://lore.kernel.org/all/ZR6EzpQb6J1TxbM8@fedora/T/? I think that would be helpful for moving the discussion forward. Thanks. |
Based on crosvm comment, the latency of an used buffer is the number of bytes before the current buffer is played:
My guess is that Crosvm is using "0" because it notifies the guest after the current period has been consumed. We could add a comment to explain that too at
vhost-device/staging/vhost-device-sound/src/lib.rs
Line 261 in 573e592
The text was updated successfully, but these errors were encountered: