Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packed_simd benchmark is broken on the latest master #765

Closed
Aaron1011 opened this issue Sep 21, 2020 · 3 comments
Closed

packed_simd benchmark is broken on the latest master #765

Aaron1011 opened this issue Sep 21, 2020 · 3 comments

Comments

@Aaron1011
Copy link
Member

This appears to have been broken by rust-lang/rust#76295

Steps to reproduce:

  1. Run rustup-toolchain-install-master 0f9f0b384a0a3c997c1ea8f838f5591f12f96633
  2. Run cargo +0f9f0b384a0a3c997c1ea8f838f5591f12f96633 check from the collector/benchmarks/packed-simd directory
  3. Note the following error:
error[E0635]: unknown feature `mmx_target_feature`
   --> src/lib.rs:212:5
    |
212 |     mmx_target_feature,
    |     ^^^^^^^^^^^^^^^^^^

This is currently causes issues with perf runs. No indication is being given that this job is failing - instead, it's just not showing up on https://perf.rust-lang.org at all.

@Mark-Simulacrum
Copy link
Member

https://perf.rust-lang.org/status.html notes the problem. I do see that it's missing in the comparison page, that's an oversight that should get fixed.

I fixed the packed-simd crate now though and it should get picked up in the next build.

@rylev
Copy link
Member

rylev commented Nov 2, 2020

@Mark-Simulacrum Can this be closed? This issue seems to be fixed

@Mark-Simulacrum
Copy link
Member

Yes, indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants