Deny WHERE_CLAUSE_OBJECT_SAFETY in Rust 2021 #81992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
rylev
added
I-nominated
T-lang
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
crlf0710
added
the
D-edition
|
In discussions on lints for editions in #80165 it was decided that this particular lint represents a bug fix and as such can be converted into an error for all editions at some point in the future. We might do a crater run to determine if this would break too much of the ecosystem in which case we might make this on an edition. I'm going to close this for now though until any relevant decision is made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #80165 this upgrades the WHERE_CLAUSE_OBJECT_SAFETY lint from Warn to Deny in the 2021 edition. In practice this doesn't change very much as the compiler is still compiled in 2018 edition.
There is active discussion on whether a deny by default lint is the right path or whether this should be handled in another part of the compiler as a hard error. This PR can be used to further that discussion.
r? @nikomatsakis