Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hack for test --stage 0 --doc std #98728

Closed
jyn514 opened this issue Jun 30, 2022 · 1 comment · Fixed by #98731
Closed

Fix hack for test --stage 0 --doc std #98728

jyn514 opened this issue Jun 30, 2022 · 1 comment · Fixed by #98731
Assignees
@b-ncMN
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Jun 30, 2022 •
edited by rustbot
Loading

In #95993 I added a hack to bootstrap that special-cased sysroot handling for doctests. Since rust-lang/cargo#10560 has been merged, we can remove the hack - I think just reverting the PR should still work, although you should test locally.
@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 30, 2022
@b-ncMN
Copy link
Contributor

b-ncMN commented Jun 30, 2022

@rustbot claim

@b-ncMN b-ncMN mentioned this issue Jun 30, 2022
Merged
@bors bors closed this as completed in a5c6a48 Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b-ncMN b-ncMN

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert #95993 fix b-ncMN/rust
2 participants
@jyn514 @b-ncMN