Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test --stage 0 library/std in CI #95996

Closed
jyn514 opened this issue Apr 13, 2022 · 5 comments · Fixed by #99040
Closed

Run test --stage 0 library/std in CI #95996

jyn514 opened this issue Apr 13, 2022 · 5 comments · Fixed by #99040
Assignees
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc P-high High priority T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Apr 13, 2022

These tests were recently broken by #95449. It shouldn't be possible for these to be broken on master - nearly everyone who contributes to the standard library uses --stage 0, and this makes it very hard to verify changes.

We should get these running in mingw-check or some other builder.

@rustbot label +P-high +A-testsuite +T-libs

Originally posted by @Mark-Simulacrum in #95993 (comment)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc P-high High priority T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 13, 2022
@gimbling-away
Copy link
Contributor

@rustbot claim

@gimbling-away
Copy link
Contributor

cc @pietroalbini Any idea re this? :)

@jyn514
Copy link
Member Author

jyn514 commented Jul 7, 2022

@gimbles here's where the code for mingw check lives:

ENV SCRIPT python3 ../x.py --stage 2 test src/tools/expand-yaml-anchors && \
python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu --all-targets && \
python3 ../x.py build --stage 0 src/tools/build-manifest && \
python3 ../x.py test --stage 0 src/tools/compiletest && \
python3 ../x.py test --stage 2 src/tools/tidy && \
python3 ../x.py doc --stage 0 library/test && \
/scripts/validate-toolstate.sh && \
/scripts/validate-error-codes.sh && \
# Runs checks to ensure that there are no ES5 issues in our JS code.
es-check es6 ../src/librustdoc/html/static/js/*.js && \
eslint -c ../src/librustdoc/html/static/.eslintrc.js ../src/librustdoc/html/static/js/*.js

that job is also run on a full merge (bors r+) so it should be enough to only modify that.

@gimbling-away
Copy link
Contributor

Awesome, thanks!

@gimbling-away
Copy link
Contributor

Should be resolved by #99040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc P-high High priority T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants