Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental compilation ICE with predicates_of #84341

Open
Aaron1011 opened this issue Apr 19, 2021 · 2 comments
Open

Incremental compilation ICE with predicates_of #84341

Aaron1011 opened this issue Apr 19, 2021 · 2 comments
Labels
A-incr-comp Area: Incremental compilation C-bug Category: This is a bug. E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Aaron1011
Copy link
Member

Aaron1011 commented Apr 19, 2021

Anyone encountering this issue (or an issue linked here) can run either cargo clean or cargo clean -p <your_package_name> as a temporary workaround.

Since #83007 was merged, we now ICE during incremental compilation when the hash of a re-computed query result does not match the hash from a previous session.

There have been a very large number of bug reports, all involving predicates_of:

There are several common characteristics across these issues

  • All of them involve calling predicate_of on a trait from the standard library, not user code.
  • All of them involve remapped paths pointing into the local standard library source code.

I've been able to reproduce similar crashes to these by adding or removing the rust-src component between compilation sessions

@Aaron1011 Aaron1011 added C-bug Category: This is a bug. A-incr-comp Area: Incremental compilation I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-high High priority labels Apr 19, 2021
@JohnTitor JohnTitor added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 24, 2021
@Aaron1011
Copy link
Member Author

Aaron1011 commented Apr 24, 2021

Blocked on #83813

@Aaron1011
Copy link
Member Author

Aaron1011 commented May 1, 2021

This was fixed by #84233, but still needs a regression test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: Incremental compilation C-bug Category: This is a bug. E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants