Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use atty crate instead of rolling our own #80888

Closed
camelid opened this issue Jan 10, 2021 · 0 comments · Fixed by #80897
Closed

Use atty crate instead of rolling our own #80888

camelid opened this issue Jan 10, 2021 · 0 comments · Fixed by #80897
Assignees
@camelid
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Jan 10, 2021

Currently the driver and some other parts of the compiler roll their own
functions to detect if they are connected to a TTY. We should instead use
something like the atty crate (which we already depend on).
@camelid camelid added A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Jan 10, 2021
@camelid camelid self-assigned this Jan 11, 2021
This was referenced Jan 11, 2021
Merged
Closed
@bors bors closed this as completed in d682a68 Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camelid camelid

Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

driver: Use atty instead of rolling our own camelid/rust
1 participant
@camelid