Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync::Weak::{from_raw, into_raw} should take a ?Sized pointer #78457

Closed
nicbn opened this issue Oct 28, 2020 · 1 comment
Closed

sync::Weak::{from_raw, into_raw} should take a ?Sized pointer #78457

nicbn opened this issue Oct 28, 2020 · 1 comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@nicbn
Copy link
Contributor

nicbn commented Oct 28, 2020

Currently sync::Weak::{from_raw, into_raw} only accepts sized pointers. I think this is an oversight as Arc::{from_raw, into_raw} accepts unsized, and sync::Weak::into_raw even manipulates the data portion of the pointer so that unsized works as well.
@jonas-schievink jonas-schievink added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Oct 28, 2020
@nicbn
Copy link
Contributor Author

nicbn commented Dec 21, 2020 •
edited
Loading

Fixed by #74160.

@nicbn nicbn closed this as completed Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonas-schievink @nicbn