Suggestion for pub(crate) and reexports are tricked

[alexcrichton]

First reported upstream, this code:

#![warn(unreachable_pub)]
#![deny(unused_imports)]

pub mod core {
    pub mod compiler {
        mod context {
            mod compilation_files {
                pub struct Metadata;
                pub struct CompilationFiles;
                impl CompilationFiles {
                    pub fn metadata() -> Metadata { Metadata }
                }
            }
            use self::compilation_files::CompilationFiles;
            pub use self::compilation_files::Metadata;  // Suggests pub(crate)
                                // but that causes unused_imports to complain.

            pub struct Context;
            impl Context {
                pub fn files() -> CompilationFiles { CompilationFiles }
            }
        }
        pub use self::context::Context;
    }
}

generates the warning

warning: unreachable `pub` item
  --> src/lib.rs:15:13
   |
15 |             pub use self::compilation_files::Metadata;  // Suggests pub(crate)
   |             ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |             |
   |             help: consider restricting its visibility: `pub(crate)`
   |
note: lint level defined here
  --> src/lib.rs:1:9
   |
1  | #![warn(unreachable_pub)]
   |         ^^^^^^^^^^^^^^^
   = help: or consider exporting it for use by other crates

warning: unreachable `pub` item
  --> src/lib.rs:15:21
   |
15 |             pub use self::compilation_files::Metadata;  // Suggests pub(crate)
   |             ---     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |             |
   |             help: consider restricting its visibility: `pub(crate)`
   |
   = help: or consider exporting it for use by other crates

but the suggested fix doesn't compile!

[jhpratt]

Related? #64762

[JoshMcguigan]

I believe rust-lang/rust-analyzer#8056 is another occurrence of this.