Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crater runs for beta 1.31 #55540

Closed
pietroalbini opened this issue Oct 31, 2018 · 48 comments
Closed

Crater runs for beta 1.31 #55540

pietroalbini opened this issue Oct 31, 2018 · 48 comments
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@pietroalbini
Copy link
Member

cc @rust-lang/release
@pietroalbini
Copy link
Member Author

@craterbot run name=beta-1.31-1 start=1.30.0 end=beta-2018-10-30 cap-lints=warn p=1

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.31-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Oct 31, 2018
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.31-1 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini pietroalbini added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Oct 31, 2018
@Mark-Simulacrum
Copy link
Member

Just as a note this beta is odd since it bootstraps from an older stable than it should I believe

@cuviper
Copy link
Member

cuviper commented Oct 31, 2018

The current beta inherited nightly's bootstrap from 1.30-beta (2018-10-13), rather than using 1.30 stable, but that's not much difference. #55550 updates this.

@Mark-Simulacrum
Copy link
Member

Yes, it shouldn't have any impact on the crater run but wanted to make that note.

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.31-1 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 3, 2018
@Mark-Simulacrum
Copy link
Member

@craterbot run name=beta-1.31-2 start=1.30.0 end=beta-2018-11-13 cap-lints=warn p=5

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.31-2 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2018
@pietroalbini
Copy link
Member Author

@craterbot start=1.30.1

@craterbot
Copy link
Collaborator

📝 Configuration of the beta-1.31-2 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.31-2 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini
Copy link
Member Author

@craterbot run start=1.30.1 end=beta-2018-11-17 mode=rustdoc cap-lints=warn p=5

@craterbot
Copy link
Collaborator

👌 Experiment pr-55540 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini
Copy link
Member Author

@craterbot abort name=pr-55540

@craterbot
Copy link
Collaborator

🗑️ Experiment pr-55540 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 17, 2018
@pietroalbini
Copy link
Member Author

@craterbot run name=beta-1.31-3 start=1.30.1 end=beta-2018-11-17 mode=rustdoc cap-lints=warn p=5

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.31-3 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2018
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.31-3 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.31-2 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Nov 24, 2018
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.31-4 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.31-4 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 27, 2018
@alexcrichton
Copy link
Member

I've found two regression in that last report: #56316 and #56317

@pietroalbini
Copy link
Member Author

Last beta run for this cycle!

@craterbot run start=1.30.1 end=master#8940af3cea4a9a9deabcaf843b2f8cad9a83fc61 mode=build-and-test cap-lints=warn p=5

@craterbot
Copy link
Collaborator

👌 Experiment pr-55540 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2018
@craterbot
Copy link
Collaborator

🚧 Experiment pr-55540 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini
Copy link
Member Author

@craterbot abort

@craterbot
Copy link
Collaborator

🗑️ Experiment pr-55540 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 30, 2018
@pietroalbini
Copy link
Member Author

@craterbot run name=beta-1.31-5 start=1.30.1 end=master#8940af3cea4a9a9deabcaf843b2f8cad9a83fc61 mode=build-and-test cap-lints=warn p=5

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.31-5 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2018
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.31-5 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.31-5 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 3, 2018
@pietroalbini
Copy link
Member Author

No new regression found (thanks @Centril and @alexcrichton for helping triaging the results!).

@nikic
Copy link
Contributor

nikic commented Dec 3, 2018 •
edited
Loading

Scary LLVM assertions:

crushtool:

Dec 03 14:51:48.263 INFO [stderr] rustc: /checkout/src/llvm/lib/IR/Type.cpp:241: static llvm::IntegerType *llvm::IntegerType::get(llvm::LLVMContext &, unsigned int): Assertion `NumBits >= MIN_INT_BITS && "bitwidth too small"' failed.

simdnoise:

Dec 02 16:48:59.627 INFO [stderr] rustc: /checkout/src/llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:118: static uint8_t (anonymous namespace)::X86MCCodeEmitter::ModRMByte(unsigned int, unsigned int, unsigned int): Assertion `Mod < 4 && RegOpcode < 8 && RM < 8 && "ModRM Fields out of range!"' failed.

@alexcrichton
Copy link
Member

@nikic agreed! Some investigation figured out those weren't regressions though and date back as far as 1.28.0. (we don't have cached builds further back than that for rustc builds linking against an LLVM with assertions enabled) Those two assertions were spawned off into #56482 and #56483

@pietroalbini
Copy link
Member Author

A note for why this is happening: this Crater run did use a start toolchain assertions disabled (1.30.1) and an end toolchain with assertions enabled (the beta commit), so all the llvm assertions caught were marked as regressions.

@nikic
Copy link
Contributor

nikic commented Dec 4, 2018

That's reassuring! I was afraid the LLVM changes in the last batch of beta backports broke something...

Could you please tell me where one can download the rustc alt build used here?

@alexcrichton
Copy link
Member

@nikic the easiest way is likely using this crate with the --alt CLI flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@cuviper @alexcrichton @nikic @Aaron1011 @pietroalbini @Mark-Simulacrum @craterbot