libc fails to migrate

[nikomatsakis]

@teiesti helpfully reported that libc fails to migrate successfully:

branch here

$ cargo +nightly build
   Compiling libc v0.2.41 (file:///home/tobias/dev/libc)
error[E0463]: can't find crate for `dox`
   --> src/macros.rs:44:16
    |
44  |           impl ::dox::Copy for $i {}
    |                  ^^^ can't find crate
    | 
   ::: src/unix/mod.rs:19:1
    |
19  | / s! {
20  | |     pub struct group {
21  | |         pub gr_name: *mut crate::c_char,
22  | |         pub gr_passwd: *mut crate::c_char,
...   |
186 | |     }
187 | | }
    | |_- in this macro invocation

error: aborting due to previous error

[aturon]

cc @alexcrichton

[Mark-Simulacrum]

Milestoned for preview 2, needs to be diagnosed/checked. Not critical to fix by then; fix by RC.

[alexcrichton]

Ok running this locally it looks like there's two separate bugs here.

• First is that cargo fix isn't yet handling exact duplicate fixes (aka two lint suggestions for the same suggestion for the exact same span of code). This is the same bug as cargo fix: "Cannot replace slice of data that was already replaced" cargo#5785 and is being fixed in Update the Cargo submodule and rustfix #52720
• Second is that we don't handle generics well, for example ::foo<::Bar> gets overlapping suggestions, one for the whole path and one for the generic parameter. This was also reported as cargo fix: Adjusting a path in a turbofish doesn't work when also adjusting the outer path cargo#5797 and reported a standalone issue for this at Lint suggesting crate:: makes overlapping suggestions #52754. Otherwise this can also be tracked in Cargo with cargo-fix: Overlapping suggestions should be discarded and cargo-fix rerun. cargo#5813 which has some thoughts about how to make progress.

With all that I think this is pretty well in hand, so closing.