Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Expand collapsed implementation when clicking on indexed methods #48726

Closed
pravic opened this issue Mar 4, 2018 · 1 comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@pravic
Copy link
Contributor

pravic commented Mar 4, 2018

Stable documentation (e.g. https://doc.rust-lang.org/stable/std/collections/hash_map/struct.HashMap.html):

Page will be scrolled to the pub fn iter.

Nightly documentation (e.g. https://doc.rust-lang.org/nightly/std/collections/hash_map/struct.HashMap.html):

Nothing will happen, because the iter is inside a collapsed impl<K, V, S> HashMap<K, V, S> outer section.

@TimNN TimNN added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Mar 6, 2018
@ehuss
Copy link
Contributor

ehuss commented Jun 27, 2018

Another example: Click the word flush in the description on the page https://doc.rust-lang.org/nightly/std/io/struct.BufWriter.html. Nothing happens, making it appear that the link is broken. Since trait impls are collapsed by default, AFAIK there is no way to properly link to them.

I'm guessing this would need to be implemented in hashchange and autoCollapse, and check if the block is hidden?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants