Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for release notes of #129422: Gate repr(Rust) correctly on non-ADT items #129958

Open
2 of 3 tasks
rustbot opened this issue Sep 4, 2024 · 3 comments
Open
2 of 3 tasks
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release ntoes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2024

This issue tracks the release notes text for #129422.

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text:

The responsible team for the underlying change should edit this section to replace the
automatically generated link with a succinct description of what changed, drawing upon text
proposed by the author (either in discussion or through direct editing). If the change is notable
enough for inclusion in the blog post, add content to the blog section below.

# Compatibility Notes
- [Rust will now correctly raise an error for `repr(Rust)` written on non-`struct`/`enum`/`union` items, since it previous did not have any effect](https://github.com/rust-lang/rust/pull/129422)

Note: The section title will be de-duplicated by the release team with other release notes issues.
Please use a standard title from previous releases.
More than one section can be included if needed.

Release blog section (if any, leave blank if no section is expected):

cc @compiler-errors, @fmease -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release ntoes. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 4, 2024
@fmease
Copy link
Member

fmease commented Sep 4, 2024

T-release, I've tentatively nominated that PR for relnotes/compat/minor_breaking_change. If you think that's overkill, feel free to remove the nomination and close this issue :)

@fmease fmease added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 4, 2024
@fmease
Copy link
Member

fmease commented Sep 4, 2024

Instead of Gate repr(Rust) correctly on non-ADT items we might want to go for Reject repr(Rust) on items that aren't structs/enums/unions in RELEASES.md which should be easier for laypeople to understand.

@compiler-errors
Copy link
Member

compiler-errors commented Sep 4, 2024

Yeah, "Rust will now correctly raise an error for repr(Rust) written on non-struct/enum/union items, since it previous did not have any effect" or something.

@rustbot rustbot added this to the 1.83.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release ntoes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants