Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./x.py test tidy should not count untracked paths towards entries limit #103951

Closed
JhonnyBillM opened this issue Nov 4, 2022 · 1 comment · Fixed by #103958
Closed

./x.py test tidy should not count untracked paths towards entries limit #103951

JhonnyBillM opened this issue Nov 4, 2022 · 1 comment · Fixed by #103958
Assignees

Comments

@JhonnyBillM
Copy link
Contributor

JhonnyBillM commented Nov 4, 2022

When browsing folders in macOS' Finder app, the OS automatically creates a .DS_Store file in the folder you're browsing. .DS_Store is usually included in .gitignore by users, making it trickier to detect which file increased the entries count in a given folder when getting the following error:

tidy error: following path contains more than 948 entries, you should move the test to some relevant subdirectory (current: 949): …/rust/src/test/ui

Because of scenarios like this, and because of the original purpose of the entries check described in #73494, tidy should ignore untracked files and directories inside tests directories.

Related links:

@chenyukang
Copy link
Member

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants