Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-ASCII identifiers in syntax highlighting #724

Open
Alphare opened this issue Jun 17, 2021 · 5 comments
Open

Support non-ASCII identifiers in syntax highlighting #724

Alphare opened this issue Jun 17, 2021 · 5 comments
Labels
upstream Caused by a third-party component

Comments

@Alphare
Copy link

Alphare commented Jun 17, 2021

rust-lang/rust#83799 has been stabilized in 1.53, which means that my first name is now a valid Rust identifier. While this is great news, turns out that only rapha in raphaël is highlighted as a function name.

I am not sure how this is implemented now, but I suspect the regex needs to be adjusted to accept all valid unicode characters under this new feature.

@shepmaster shepmaster added the upstream Caused by a third-party component label Jun 17, 2021
@shepmaster
Copy link
Member

You will need to submit a pull request to the Ace editor.

@shepmaster shepmaster changed the title Support non-ascii identifiers in syntax highliting Support non-ASCII identifiers in syntax highlighting Jun 17, 2021
@Alphare
Copy link
Author

Alphare commented Jun 23, 2021

Sorry, I forgot about this. Will do, thanks. :)

@Alphare
Copy link
Author

Alphare commented Jun 23, 2021

Opened ajaxorg/ace#4519, thanks.

@Alphare Alphare closed this as completed Jun 23, 2021
@shepmaster shepmaster reopened this Jun 23, 2021
@shepmaster
Copy link
Member

I like to leave these open to keep tabs on things we will need to update eventually. 😉

@camelid
Copy link
Member

camelid commented Sep 5, 2021

Looks like the upstream issue has been fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Caused by a third-party component
Projects
None yet
Development

No branches or pull requests

3 participants