Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong_self_convention fails for libstd RawEntryBuilderMut::from_key #3858

Open
gnzlbg opened this issue Mar 8, 2019 · 1 comment
Open

wrong_self_convention fails for libstd RawEntryBuilderMut::from_key #3858

gnzlbg opened this issue Mar 8, 2019 · 1 comment
Labels
C-bug Category: Clippy is not doing the correct thing

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 8, 2019

libstd RawEntryBuilderMut::from_key is a builder, which takes self as first argument and the key to use as a second argument. This seems ok, but wrong_self_convention lints it.

https://doc.rust-lang.org/std/collections/hash_map/struct.RawEntryBuilderMut.html#method.from_key

@oli-obk oli-obk added the C-bug Category: Clippy is not doing the correct thing label Mar 11, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Mar 11, 2019

I'm not sure which part it is complaining about, if it is the fact that there are two arguments, we should not emit the lint if an argument is Self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing
Projects
None yet
Development

No branches or pull requests

2 participants