Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to settle the behaviour of floating-point in const #222

Closed
scottmcm opened this issue Oct 3, 2023 · 4 comments
Closed

We need to settle the behaviour of floating-point in const #222

scottmcm opened this issue Oct 3, 2023 · 4 comments
Labels
meeting-proposal Proposal for a lang team design meeting T-lang

Comments

@scottmcm
Copy link
Member

scottmcm commented Oct 3, 2023

Summary

We need to settle what matching means -- is it bitwise structural on the non-padding? is it PartialEq? -- and in particular what are the implications of that for floats (with NAN and ±0 and ...)

Per niko this has been an issue since Rust 0.8; it would be really nice to resolve it 🙂

Background reading

rust-lang/rust#116098
rust-lang/rust#116284

(scottmcm is opening this as requested in the 2023-10-03 lang meeting, but doesn't really have the context to write a doc for the meeting)

Include any links to material that folks ought to try to read before-hand.

About this issue

This issue corresponds to a lang-team design meeting proposal. It corresponds to a possible topic of discussion that may be scheduled for deeper discussion during one of our design meetings.

@scottmcm scottmcm added meeting-proposal Proposal for a lang team design meeting T-lang labels Oct 3, 2023
@RalfJung
Copy link
Member

RalfJung commented Oct 3, 2023

I think this should be part of #220.

@RalfJung
Copy link
Member

@scottmcm the title talks about FP in const in general, but I think you actually mean FP in patterns?

We didn't get to this when meeting for #220 so this might still warrant a separate meeting.

@pnkfelix
Copy link
Member

cc rust-lang/rfcs#3514

@joshtriplett
Copy link
Member

I think we've now addressed this with RFCs. If there are any remaining open items on this, please feel free to reopen (or file a nominated issue asking us to do so).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting-proposal Proposal for a lang team design meeting T-lang
Projects
Development

No branches or pull requests

4 participants