Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge all rustwide build directories before each build #2250

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

syphar
Copy link
Member

@syphar syphar commented Oct 6, 2023

I see this as a temporary solution so we can run the second builder without filling up disk space. Resolves #820 for now.

The real solution is to refactor the builder structure, probably with the work I'll do related to #1011 .

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 6, 2023
@syphar syphar force-pushed the clear-workspace-before-build branch from e3faf78 to 693b4d6 Compare October 6, 2023 06:42
@syphar syphar force-pushed the clear-workspace-before-build branch from 693b4d6 to 3455c72 Compare October 6, 2023 13:59
@syphar syphar requested a review from Nemo157 October 6, 2023 13:59
@syphar syphar merged commit 5e249fc into rust-lang:master Oct 6, 2023
6 checks passed
@syphar syphar deleted the clear-workspace-before-build branch October 6, 2023 15:18
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 6, 2023
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target directories are not purged after build failures
2 participants