Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache build results per feature matrix for dependencies #3245

Closed
dhardy opened this issue Nov 2, 2016 · 2 comments
Closed

Cache build results per feature matrix for dependencies #3245

dhardy opened this issue Nov 2, 2016 · 2 comments

Comments

@dhardy
Copy link

dhardy commented Nov 2, 2016

Concrete example:

git clone https://github.com/maidsafe/routing.git && cd routing
cargo build
cargo build --features=clippy
cargo build

All three build commands causes many dependencies to be rebuilt from scratch. I would expect the third command not to rebuild dependencies which had already been built with the current feature matrix; currently toml, log4rs, maidsafe_utilities, crust and routing itself get rebuilt by the last build command.

Note that when switching release and debug builds, Cargo does cache dependency builds and not force a rebuild when switching.

@alexcrichton
Copy link
Member

Thanks for the report! This is actually the topic of #3102, which I believe should fix this

@dhardy
Copy link
Author

dhardy commented Nov 2, 2016

Great!

@dhardy dhardy closed this as completed Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants