-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement Deref trait for SecretKey #245
Comments
What would they |
I thought they would |
|
A. The internal representation of PublicKey is Implementation Defined, so to impl |
I agree with A. Let me adjust the issue title to reflect that. About B: Still, the inconsistency between |
Don't get me started on "magic" in golang :) (comments are magic, the amount of return values from maps/channels is magically chosen by how many lvalues you have, cgo is 100% pure magic, which pointers the GC tracks is magic, should I continue? :) ) |
I think |
In any case -- I think we should probably go in the direction of removing access to the internal representation (or providing a |
The
Deref
trait is implemented forSharedSecret
andSerializedSignature
. I was wondering if you have considered implementing that trait also forPublicKey
andSecretKey
already?The text was updated successfully, but these errors were encountered: