Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources receiving their configs from another directory are blocked with --restrict-file-list parameter #4971

Open
ibalat opened this issue Oct 1, 2024 · 2 comments
Labels
bug Something isn't working feature New functionality/enhancement

Comments

@ibalat
Copy link

ibalat commented Oct 1, 2024

Hi @Fabianoshz , thanks for your contribute (#2440), this feature is very important for our monolithic repos security. But we have an failed scenario for this feature:

I have an resource getting configs from subfolder and when I change any config, I can't run atlantis command because of changes at subfolder.

My resource location: clusters/dev/main.tf
Config location: clusters/dev/configs/dashboards/application
I have to apply resource in main.tf

my resource is getting configs from another location:

grafana_dashboard_kubernetes = {
    for dashboard in fileset("${path.module}/configs/dashboards/application/", "*.json") :
    dashboard => file("${path.module}/grafana/configs/application/${dashboard}")
  }

Can we add recursive check? Or another parameter is available to fix it?

@ibalat ibalat added the feature New functionality/enhancement label Oct 1, 2024
@dosubot dosubot bot added the bug Something isn't working label Oct 1, 2024
@Fabianoshz
Copy link
Contributor

Fabianoshz commented Oct 1, 2024

Hi @ibalat, I'm not an active contributor anymore as I'm not using Atlantis anymore.

Looking at the code it seems to be easy to fix though, so I might give it a shot if I manage to find some time.

@ibalat
Copy link
Author

ibalat commented Oct 1, 2024

@Fabianoshz thanks for your fastly reply. I have opened a PR. Please can you review it? #4972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

2 participants