Update base.py #15070
Merged
Update base.py #15070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the average_rating bug
dosubot
bot
added
the
size:XS
logan-markewich
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the average_rating bug
Description
After merging the PR (#15047), the bug is still not fully fixed. When I print the average rating in the data loader, the data type is now correct but the value seems to be casted from an integer:
Little Hunan Restaurant has rating: 5.0
Hot Wok Bistro has rating: 4.0
Little Shanghai Restaurant has rating: 2.0
Oceanic Restaurant has rating: 3.0
Town of dumpling has rating: 5.0
It is due to another bug that the rating was overwritten by the inner loop (line 75), we can fix it by renaming the variable. Please note that in Google's response, the place.rating field is the average rating.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist: