Support for Re-Ranker via Text Embedding Interface #15063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
| @@ -23,6 +23,7 @@ | |||
| PIINodePostprocessor, | |||
| ) | |||
| from llama_index.core.postprocessor.sbert_rerank import SentenceTransformerRerank | |||
| from llama_index.core.postprocessor.tei_rerank import TextEmbeddingInference | |||
There was a problem hiding this comment.
tbh I would prefer that this isn't in core (and actually, I have no idea why sbert is in core either, that should also be removed in another PR)
There was a problem hiding this comment.
Sure, made the changes.
There was a problem hiding this comment.
Can we put a sample install command and some example of usage? This readme will show up on https://llamahub.ai
There was a problem hiding this comment.
Can do, will make the necessary changes and push it soon.
There was a problem hiding this comment.
Pushed the changes, hope that covers it 😃
| license = "MIT" | ||
| name = "llama-index-postprocessor-tei-rerank" | ||
| readme = "README.md" | ||
| version = "0.1.6" |
There was a problem hiding this comment.
probably should start at v0.1.0?
There was a problem hiding this comment.
yup, my bad! forgot to change this.
logan-markewich
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Text Embedding Inference by Huggingface supports hosting re-ranker models, which at the moment are not supported by llama-index post processing module.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods