Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 fix(core): fix file reader bug #14537

Merged
merged 1 commit into from
Jul 3, 2024
Merged

🐞 fix(core): fix file reader bug #14537

merged 1 commit into from
Jul 3, 2024

Conversation

houtaroy
Copy link
Contributor

@houtaroy houtaroy commented Jul 3, 2024

Description

when I run S3Reader Test in Windows, func test_list_and_read_file_workflow cause error, then I found the resaon and fix SimpleDirectoryReader.load_resource, select right path function to resource_id

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

run core/readers test and S3Reader test

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

fix SimpleDirectoryReader.load_resource, select right path function to resource_id
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 3, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) July 3, 2024 15:44
@logan-markewich logan-markewich merged commit bbadb3a into run-llama:main Jul 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants