Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: follow up with kwargs propagation due to change in parent class #14522

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

tibor-reiss
Copy link
Contributor

@tibor-reiss tibor-reiss commented Jul 2, 2024

Description

Fixes #14398: index_name is passed into the constructor. Since it is not a keyword argument in the parent constructor, it is moved into kwargs. However, #14341 passes these kwargs into build_index_from_nodes, so this needs to be done for the child implementation as well in _build_index_from_nodes.

Fixes #14398

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 2, 2024
@tibor-reiss tibor-reiss changed the title Follow up with kwargs propagation due to change in parent class Fix: follow up with kwargs propagation due to change in parent class Jul 2, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 3, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) July 3, 2024 15:53
@logan-markewich logan-markewich merged commit eee0f9e into run-llama:main Jul 3, 2024
8 checks passed
@tibor-reiss tibor-reiss deleted the fix-14398-index-name branch July 3, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeError: ColbertIndex._build_index_from_nodes() got an unexpected keyword argument 'index_name'
2 participants