Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Local Deployment of Firecrawl #14452

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Conversation

busaud
Copy link
Contributor

@busaud busaud commented Jun 28, 2024

Description

Adding api_url to enable local deployment of Firecrawl

Fixes # (N/A)

New Package? NO

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No
  • [ x ] N/A

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • [ x ] Yes
  • No

Type of Change

Please delete options that are not relevant.

  • [ x ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • [ x ] I stared at the code and made sure it makes sense

^^ To be honest, I am not sure how to build a test for it as the local deployment of Firecrawl is quite hardware intensive. Also, I am not sure how to manually test this implementation locally as I couldn't find the source code on the site-packages on my machine unlike the llama-index-core.

Suggested Checklist:

  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 28, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 1, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) July 1, 2024 17:14
@logan-markewich logan-markewich merged commit 2308d70 into run-llama:main Jul 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants