Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert script to Kotlin and merge into StreetComplete? #58

Open
westnordost opened this issue Oct 12, 2020 · 1 comment
Open

Convert script to Kotlin and merge into StreetComplete? #58

westnordost opened this issue Oct 12, 2020 · 1 comment

Comments

@westnordost
Copy link

I recently reworked the whole build scripts of StreetComplete. Before, there was a mix of python, groovy and "JUnit" scripts, each of them had to be executed manually.

Now, all build scripts, and I mean also scripts that collect data and generate metadata are all written in Kotlin and are all here:
https://github.com/westnordost/StreetComplete/tree/master/buildSrc

Why am I telling you this? Because now this is an oppurtunity to have your crops parser run as part of the build process in StreetComplete too, or to be more precise, as part of the scripts that update the country_metadata (which might move to a separate repository one day). You'd just need to rewrite the parser as a kotlin task. What do you think?

@rugk
Copy link
Owner

rugk commented Oct 12, 2020

Thanks for the nice, yeah, technically it's a great idea.

Also, if I had to rewrite this, I certainly would not choose bash scripts again, they are hardly suitable for that task. (As the filtering etc. was more complex than I initially thought.)
I would possibly use Python next time.

But yeah, likely you can also properly do it in Kotlin, though I have no experience in that.

Anyway, I totally agree rewriting this would be a very good idea. That said, I likely won't have much time for this (I assume quite big task) in the next time, so I'll mark this with "help wanted".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants