Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PACKS] #12 Item view should include all fields (including new custom request units) #4407

Closed
cielf opened this issue May 30, 2024 · 4 comments · Fixed by #4431
Closed

[PACKS] #12 Item view should include all fields (including new custom request units) #4407

cielf opened this issue May 30, 2024 · 4 comments · Fixed by #4431
Assignees
Labels
Ruby for Good 2024 DC Issues for RFG 2024 DC

Comments

@cielf
Copy link
Collaborator

cielf commented May 30, 2024

Summary

The view of the item doesn't currently show all the fields they can edit. It should. That includes any custom request units on the item.

Why

So the banks have one stop for all the info on the item.

Details

Items | Items & Inventory | View

Reorganize the information above "This Item is Contained in These Inventories" so that it can include all the fields directly entered for the item

Base Item
Name
Value Per Item
Category
Quantity Per Individual
On hand minimum quantity
On hand recommended quantity
Package size
Item is visible to partners
Custom request units (if any)

Image

NB

The Custom request units bit must be behind the flipper flag "enable_packs" , but the rest of the change can and should be put in without it.

@cielf cielf added the Ruby for Good 2024 DC Issues for RFG 2024 DC label May 30, 2024
@awwaiid awwaiid added this to the Packs milestone May 31, 2024
@Naraveni
Copy link
Contributor

Naraveni commented Jun 4, 2024

I would like to this please

@cielf
Copy link
Collaborator Author

cielf commented Jun 5, 2024

Please do.

@Naraveni
Copy link
Contributor

Naraveni commented Jun 8, 2024

@cielf I have one doubt regarding the new data that need to be shown.

In the design you have provided,
name maps to item name
category maps to items category
what does base item does map to in item model?

@cielf
Copy link
Collaborator Author

cielf commented Jun 8, 2024

@cielf I have one doubt regarding the new data that need to be shown.

In the design you have provided, name maps to item name category maps to items category what does base item does map to in item model?

@Naraveni Item belongs to base_item. You can show item.base_item.name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby for Good 2024 DC Issues for RFG 2024 DC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants