Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error for no storage location on new audit should refer to audit not transfer. #3688

Closed
2 tasks
cielf opened this issue Jun 25, 2023 · 3 comments · Fixed by #3702
Closed
2 tasks

Error for no storage location on new audit should refer to audit not transfer. #3688

cielf opened this issue Jun 25, 2023 · 3 comments · Fixed by #3702
Assignees
Labels

Comments

@cielf
Copy link
Collaborator

cielf commented Jun 25, 2023

Summary

Improve error presentation on saving a new audit

Why fix

forestalling confusion; also more professional appearance increases user confidence

Details

If you try to save progress without picking a storage location on a new audit, you'll see something like this:

Image

There are three problems with this:

1/ The error next to the field mentions transfers. This is an audit. It should be "What location are you auditing?"
2/ The error at the top a) is a bit repetitive and b) is showing a bunch of HTML tags. It should just say something like "storage location must be selected"
3/ "From storage location" should just be "Storage Location"

Criteria for completion

  • error messages properly reflecting the audit context
  • tests to confirm
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Jun 25, 2023
@jadekstewart3
Copy link
Contributor

jadekstewart3 commented Jun 26, 2023

@cielf Can I tackle this one please?

@dorner
Copy link
Collaborator

dorner commented Jun 27, 2023

You got it!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

This issue has been inactive for 250 hours (10.42 days) and will be automatically unassigned after 110 more hours (4.58 days).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants