Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurement Views #845

Closed
5 tasks
CraigJZ opened this issue Oct 9, 2021 · 6 comments · Fixed by #862
Closed
5 tasks

Measurement Views #845

CraigJZ opened this issue Oct 9, 2021 · 6 comments · Fixed by #862
Assignees

Comments

@CraigJZ
Copy link
Collaborator

CraigJZ commented Oct 9, 2021

Currently, measurement data is available through Blazer queries. We would like to add the remaining rails views for Measurements. Editing a measurement should be limited to organization admins. We are excluding the ability to delete a measurement as that comes with additional considerations. New measurements will still be done through the import and we don't want to add an interface for these in the UI.

  • Add index, show and edit actions to Measurements
  • Add the corresponding views
  • Restrict editing to organization admin
  • Add specs exercising the new controller actions and the editing restriction
  • Add a Measurements nav item
@josephinef9
Copy link
Contributor

claiming

@josephinef9
Copy link
Contributor

@CraigJZ what columns would you like on the table for the index view? Right now I have value, subject type, date, measurement type and measurement event. The ones missing are animal tag, enclosure name, and cohort name. I can add those easily but the table gets crowded.

Also do you want the table paginated?

@CraigJZ
Copy link
Collaborator Author

CraigJZ commented Oct 12, 2021

@josephinef9 These columns sound good. If there is room, we could potentially add a column that provides the animal tag, enclosure name or cohort name based on the subject type. So, if it's a Cohort, we would show the cohort name. I don't think this is essential, though, and adds some additional complexity that wasn't in the original issue so we would also break that into a separate issue too. 😅

@josephinef9
Copy link
Contributor

@CraigJZ I totally forgot to ask when we were on zoom but what part of measurements do you want to be able to be edited?

@CraigJZ
Copy link
Collaborator Author

CraigJZ commented Oct 12, 2021

@josephinef9 The value, measurement_type, subject and subject_type.

@josephinef9
Copy link
Contributor

@CraigJZ this issue has a PR that is ready for review #862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants