⚡✅ Update debug output gsub to run in O(n)

The same string transform is simple without negative lookahead by using a block with gsub and checking `$'.empty?`.
ruby · Apr 28, 2023 · 4816f10 · 4816f10
1 parent bac5fd7
commit 4816f10
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/lib/net/imap.rb b/lib/net/imap.rb
@@ -2443,8 +2443,8 @@ def put_string(str)
         if @debug_output_bol
           $stderr.print("C: ")
         end
-        $stderr.print(str.gsub(/\n(?!\z)/n, "\nC: "))
-        if /\r\n\z/n.match(str)
+        $stderr.print(str.gsub(/\n/n) { $'.empty? ? $& : "\nC: " })
+        if /\n\z/n.match(str)
           @debug_output_bol = true
         else
           @debug_output_bol = false

diff --git a/test/net/imap/test_regexps.rb b/test/net/imap/test_regexps.rb
@@ -27,9 +27,6 @@ class IMAPRegexpsTest < Test::Unit::TestCase
       exclude_map: {
         Net::IMAP => %i[BodyTypeAttachment BodyTypeExtension], # deprecated
       },
-      exclude: [
-        /\n(?!\z)/n, # TODO (in Net::IMAP#put_string)
-      ]
     ).to_h
   )