Let Logger#reopen not raise on nil log devices

ruby · Mar 28, 2020 · c7de6ac · c7de6ac
1 parent b42a1b9
commit c7de6ac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/logger.rb b/lib/logger.rb
@@ -410,7 +410,7 @@ def initialize(logdev, shift_age = 0, shift_size = 1048576, level: DEBUG,
   # Reopen a log device.
   #
   def reopen(logdev = nil)
-    @logdev.reopen(logdev)
+    @logdev&.reopen(logdev)
     self
   end
 

diff --git a/test/logger/test_logdevice.rb b/test/logger/test_logdevice.rb
@@ -189,6 +189,13 @@ def test_reopen_file_by_file
     end
   end
 
+  def test_reopen_nil_logdev
+    logdev = d(File::NULL)
+    assert_nothing_raised do
+      logdev.reopen
+    end
+  end
+
   def test_shifting_size
     tmpfile = Tempfile.new([File.basename(__FILE__, '.*'), '_1.log'])
     logfile = tmpfile.path