Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a warning during test #535

Closed
wants to merge 1 commit into from
Closed

Conversation

mame
Copy link
Member

@mame mame commented Aug 9, 2023

Module#included method is redefined without removing the old definition, which causes a warning under verbose mode:

http://rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20230809T031004Z.log.html.gz

[ 9411/24642] JSONGeneratorTest#test_string_ext_included_calls_super/home/chkbuild/chkbuild/tmp/build/20230809T031004Z/ruby/test/json/json_generator_test.rb:411: warning: method redefined; discarding old included
/home/chkbuild/chkbuild/tmp/build/20230809T031004Z/ruby/test/json/json_generator_test.rb:399: warning: previous definition of included was here
 = 0.00 s

`Module#included` method is redefined without removing the old
definition, which causes a warning under verbose mode:

http://rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20230809T031004Z.log.html.gz
```
[ 9411/24642] JSONGeneratorTest#test_string_ext_included_calls_super/home/chkbuild/chkbuild/tmp/build/20230809T031004Z/ruby/test/json/json_generator_test.rb:411: warning: method redefined; discarding old included
/home/chkbuild/chkbuild/tmp/build/20230809T031004Z/ruby/test/json/json_generator_test.rb:399: warning: previous definition of included was here
 = 0.00 s
 ```
@hsbt
Copy link
Member

hsbt commented Sep 13, 2023

Sorry, I missed this PR. I forward-port your commit from ruby/ruby.

@hsbt hsbt closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants