Suppress Ruby warnings in certain backtrace filtering tests #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
suppress-ruby-warnings-in-certain-tests
branch
2 times, most recently
from
5068027
to
3678c40
Compare
tompng
reviewed
Jun 9, 2024
test/irb/test_irb.rb
Outdated
| def setup | ||
| super | ||
| # These tests are sensitive to warnings, so we disable them | ||
| original_rubyopt = ENV["RUBYOPT"] || "" + (@envs["RUBYOPT"] || "") |
There was a problem hiding this comment.
Precedence of the operator will be ENV["RUBYOPT"] || ("" + (@envs["RUBYOPT"] || ""))
How about this? It will make it chainable in subclasses. (expecting @envs["RUBYOPT"] already including ENV["RUBYOPT"] if it is not nil)
original_rubyopt = @envs["RUBYOPT"] || ENV["RUBYOPT"] || ""There was a problem hiding this comment.
No I think we need to include both values. So probably this instead:
original_rubyopt = [ENV["RUBYOPT"], @envs["RUBYOPT"]].compact.join(" ")
Since they're sensitive to the warnings, and the warnings are not relevant to the tests, we can suppress them to keep the tests simple.
st0012
force-pushed
the
suppress-ruby-warnings-in-certain-tests
branch
from
3678c40
to
0fd1656
Compare
tompng
approved these changes
Jun 9, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jun 9, 2024
tests (ruby/irb#966) Since they're sensitive to the warnings, and the warnings are not relevant to the tests, we can suppress them to keep the tests simple. ruby/irb@ad642795da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since they're sensitive to the warnings, and the warnings are not relevant to the tests, we can suppress them to keep the tests simple.
This should fix the current test failures on master.