Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass statements to Context#evaluate #920

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Pass statements to Context#evaluate #920

merged 1 commit into from
Apr 12, 2024

Commits on Apr 11, 2024

  1. Pass statements to Context#evaluate

    This has a few benefits:
    
    - We can keep hiding the evaluation logic inside the Context level, which
      has always been the convention until #824 was merged recently.
    - Although not an official API, gems like `debug` and `mission_control-jobs`
      patch `Context#evaluate` to wrap their own logic around it. This implicit
      contract was broken after #824, and this change restores it.
    
    In addition to the refactor, I also converted some context-level evaluation
    tests into integration tests, which are more robust and easier to maintain.
    st0012 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    bf9acb2 View commit details
    Browse the repository at this point in the history