Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type completor section of README #820

Merged
merged 4 commits into from
Dec 23, 2023
Merged

Fix type completor section of README #820

merged 4 commits into from
Dec 23, 2023

Conversation

tompng
Copy link
Member

@tompng tompng commented Dec 21, 2023

Added

  • missing table of content
  • link to repl_type_completor repo
  • installing with bundler
  • enable type completor by ENV

@tompng
Add missing table of content for type-based-completor
e6cbf0e
@tompng
Update how to enable TypeCompletor section
78c16b0 
Add link to ruby/repl_type_completor
Add how to install, (gem install, Gemfile)
Add environment variable description
st0012
st0012 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Just a few nitpicks/suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tompng tompng merged commit c2f90c4 into ruby:master Dec 23, 2023
24 checks passed
@tompng tompng deleted the readme_type_completor_fix branch December 23, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tompng @st0012