Drop Ruby 2.6 support #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
reviewed
Apr 3, 2023
|
I added the Don’t merge label so that other than st0012 will not merge it. |
|
@ima1zumi Labeling is a great idea. Thank you 🙌 |
hasumikin
approved these changes
Apr 5, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Apr 5, 2023
(ruby/irb#555) * Remove all Ruby 2.6 support * Drop Ruby 2.6 specific testing conditions * Only run Ruby 2.7+ on CI * Bump Ruby requirement to 2.7+ ruby/irb@3f714b616c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Ruby 2.7 enters EOL, I think it makes sense to drop the support of 2.6, which lacks proper kwargs support and
Ripper#scanand makes maintenance more complicated.Versioning implication
According to the semver specificaion, updating a dependency without changing any API does NOT need to bump a major version. And given we don't introduce a feature either, I think this change can safely be included in the next patch or minor release.
Please let me merge this PR myself in case I found any additional changes to make or undo.