-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename IDB::ReidlineInputMethod to IRB::RelineInputMethod #409
Conversation
Deprecates IDB::ReidlineInputMethod and USE_REIDLINE in favor of IRB::RelineInputMethod and USE_RELINE. The Input method uses Reline to read input from the console, so it can be named directly after the Reline library like other inputs methods are (Readline, Stdio, etc.).
Nice catch, Thanks! |
warn <<~MSG.strip | ||
USE_REIDLINE is deprecated, please use USE_RELINE instead. | ||
MSG | ||
@use_multiline = IRB.conf[:USE_RELINE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is for backward compatibility, shouldn't this be USE_REIDLINE
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maked sense.
@gmcgibbon Thanks for the PR. But even though most users don't use it directly, gems and apps may reference the Given the above reasons, I actually planned to put it on hold and split the changes in different levels of releases. @hsbt Can we:
I can make PRs for them if you think the approach is reasonable. |
I understood your suggestion. But I won't care about sorbet use-case because I'm not sorbet user. |
@@ -470,4 +470,13 @@ def inspect | |||
str | |||
end | |||
end | |||
|
|||
class ReidlineInputMethod < RelineInputMethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I missed this definition. I think it's a safe change and added #411 to pick up a few leftovers.
Deprecates IDB::ReidlineInputMethod and USE_REIDLINE in favor of IRB::RelineInputMethod and USE_RELINE. The Input method uses Reline to read input from the console, so it can be named directly after the Reline library like other inputs methods are (Readline, Stdio, etc.).