Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appraise parenthesis during completion #302

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

kaiquekandykoga
Copy link
Contributor

Hello guys,

This is an attempt to fix the issue #299.

When absolute constant is used with ) an exception is raised with regex during completion.

It includes ) character verification to prevent raising an exception.

After

3.0.2 :001 > defined?(::A)
 => nil

Before

3.0.2 :001 > defined?(::A)
/irb/lib/irb/completion.rb:207:in `retrieve_completion_data': unmatched close parenthesis: /^A)/ (RegexpError)

Thank you very much.

@kaiquekandykoga kaiquekandykoga changed the title Ignore parenthesis during completion Appraise parenthesis during completion Oct 10, 2021
@aycabta aycabta merged commit bd597bc into ruby:master Oct 12, 2021
@aycabta
Copy link
Member

aycabta commented Oct 12, 2021

Good catch, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants