Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove require in signal handler to avoid ThreadError #294

Conversation

pocke
Copy link
Member

@pocke pocke commented Sep 25, 2021

This PR fixes a ThreadError, which is #282.

Fix #282

Problem

IRB does require 'rdoc' in SHOW_DOC_DIALOG and it is called from a trap context. Then it causes the ThreadError.

Solution

Remove the require from the proc. It looks unnecessary because rdoc is required from the top-level of the same file.

require 'rdoc'

`rdoc` has been required so it looks unnecessary
@aycabta aycabta merged commit ffcc558 into ruby:master Oct 3, 2021
@aycabta
Copy link
Member

aycabta commented Oct 3, 2021

Thank you!

@pocke pocke deleted the Remove__require__in_signal_handler_to_avoid_ThreadError branch October 3, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ThreadError when changing window size
2 participants