Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change step with new_cop command for rubocop-rspec_rails #33

Merged
merged 1 commit into from
May 24, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented May 24, 2024

before:

Do 4 steps:
  1. Modify the description of RSpecRails/CopName in config/default.yml
  2. Implement your new cop in the generated file!
  3. Commit your new cop with a message such as
     e.g. "Add new `RSpecRails/CopName` cop"
  4. Run `bundle exec rake changelog:new` to generate a changelog entry

after:

Do 4 steps:
  1. Modify the description of RSpecRails/CopName in config/default.yml
  2. Implement your new cop in the generated file!
  3. Commit your new cop with a message such as
     e.g. "Add new `RSpecRails/CopName` cop"
  4. Add an entry about new cop to CHANGELOG.md

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

before:
```
Do 4 steps:
  1. Modify the description of RSpecRails/CopName in config/default.yml
  2. Implement your new cop in the generated file!
  3. Commit your new cop with a message such as
     e.g. "Add new `RSpecRails/CopName` cop"
  4. Run `bundle exec rake changelog:new` to generate a changelog entry
```

after:
```
Do 4 steps:
  1. Modify the description of RSpecRails/CopName in config/default.yml
  2. Implement your new cop in the generated file!
  3. Commit your new cop with a message such as
     e.g. "Add new `RSpecRails/CopName` cop"
  4. Add an entry about new cop to CHANGELOG.md
```
@ydah ydah requested a review from a team as a code owner May 24, 2024 11:44
@pirj pirj merged commit b1671cd into master May 24, 2024
25 of 27 checks passed
@pirj pirj deleted the new-cop-command branch May 24, 2024 13:28
@pirj
Copy link
Member

pirj commented May 24, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants