-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an error for Ambiguous cop name RSpec/Rails/HttpStatus
#25
Conversation
RSpec/Rails/HttpStatus
Fix: #18 This PR fixes an error for Ambiguous cop name `RSpec/Rails/HttpStatus` in the `rubocop-rspec_rails` gem.
@@ -21,7 +21,7 @@ | |||
# https://github.com/rubocop/rubocop-rspec_rails/issues/8 | |||
module RuboCop | |||
module Cop | |||
class AmbiguousCopName # rubocop:disable Style/Documentation | |||
class Registry # rubocop:disable Style/Documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 I reviewed that code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, it’s not necessary to reopen the class to prepend a module. E.g. RuboCop::Cop::Registry.prepend(Module.new
… would work fine.
@mjankowski @pirj This should fix it. |
@@ -21,7 +21,7 @@ | |||
# https://github.com/rubocop/rubocop-rspec_rails/issues/8 | |||
module RuboCop | |||
module Cop | |||
class AmbiguousCopName # rubocop:disable Style/Documentation | |||
class Registry # rubocop:disable Style/Documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, it’s not necessary to reopen the class to prepend a module. E.g. RuboCop::Cop::Registry.prepend(Module.new
… would work fine.
Nice! Thank you 😊 |
Fix: #18
This PR fixes an error for Ambiguous cop name
RSpec/Rails/HttpStatus
in therubocop-rspec_rails
gem.Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).