Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change superclass for InferredSpecType #19

Closed
wants to merge 1 commit into from

Conversation

bquorning
Copy link
Contributor

This copies some of the code from the RuboCop::RSpec::Language module in rubocop-rspec, and it no longer allows the user to configure aliases for example group methods (describe, fcontext, xfeature etc.).


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning mentioned this pull request Apr 1, 2024
6 tasks
This copies some of the code from the `RuboCop::RSpec::Language` module
in rubocop-rspec, and it no longer allows the user to configure aliases
for example group methods (`describe`, `fcontext`, `xfeature` etc.).
@bquorning bquorning marked this pull request as ready for review April 1, 2024 21:36
@bquorning bquorning requested a review from a team as a code owner April 1, 2024 21:36
@bquorning
Copy link
Contributor Author

Perhaps this does warrant a mention in the changelog?

@ydah
Copy link
Member

ydah commented Apr 1, 2024

it no longer allows the user to configure aliases for example group methods

Hmm. Users using RSwag may be in trouble. Users using RSwag and using rubocop-rspec can find it in Issue.
https://github.com/rubocop/rubocop-rspec/issues?q=is%3Aissue+rswag+is%3Aclosed

@pirj
Copy link
Member

pirj commented Apr 2, 2024

Is it worth the tradeoff? We’re not only limiting current cops from being able to confidently focus their inspection to examples/example groups, but any future cops, too.

This is the first step towards dropping the dependency on rubocop-rspec. But why?

@bquorning
Copy link
Contributor Author

🤔 I guess you’re right, as long as we keep a runtime dependency on rubocop-rspec, it should be ok to inherit from ::RuboCop::Cop::RSpec::Base.

Should I close this PR again?

@pirj
Copy link
Member

pirj commented Apr 2, 2024

I think so, yes.

@bquorning bquorning closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants