Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AutoCorrect: contextual option for LSP #1899

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

ydah
Copy link
Member

@ydah ydah commented Jun 3, 2024

Fix: #1883


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have modified an existing cop's configuration options:

  • Set VersionChanged: "<<next>>" in config/default.yml.

@ydah ydah requested a review from a team as a code owner June 3, 2024 17:05
Copy link
Collaborator

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s hard to tell if this is the correct list of cops or not, but it’s a good start. We can adjust the list based on real-world use and the resulting bug reports.

@ydah ydah merged commit e49f221 into master Jun 3, 2024
25 checks passed
@ydah ydah deleted the support-contextual branch June 3, 2024 18:00
ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Jun 3, 2024
ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Jun 3, 2024
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this pull request Jun 3, 2024
ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Jun 4, 2024
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We also need support AutoCorrect: contextual option for LSP
2 participants