Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use offense instead of violation #1680

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Use offense instead of violation #1680

merged 1 commit into from
Aug 11, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Aug 2, 2023

This PR change to use offense instead of violation. And this PR set also Naming/InclusiveLanguage.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

.rubocop.yml Outdated Show resolved Hide resolved
This PR change to use offense instead of violation.
And this PR set also `Naming/InclusiveLanguage`.
Copy link
Collaborator

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. What do you say, @pirj and @Darhazer?

Copy link
Member

@Darhazer Darhazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the accepted term we use in RuboCop so 👍 for keeping the consistency

@ydah ydah merged commit e09a701 into master Aug 11, 2023
22 checks passed
@ydah ydah deleted the use_offense branch August 11, 2023 08:36
ydah added a commit to rubocop/rubocop-capybara that referenced this pull request Aug 25, 2023
ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Aug 25, 2023
ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants